You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/02/15 14:29:48 UTC
[GitHub] flink pull request #3323: [hotfix] [core] Add missing stability annotations ...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/3323
[hotfix] [core] Add missing stability annotations for classes in flink-core
Several classes in `flink-core` do not have a stability annotation.
I went over the classes which were added since Flink 1.1.0 (and some that I found on the way) and added `@PublicEvolving` and `@Internal` annotations.
The PR is split into two commits, one for each annotation.
Please validate the annotations I added @StefanRRichter, @zentol, @twalthr
Thanks, Fabian
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink stability
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3323
----
commit b4e64e59fe062e67ff07c80d55da962c30f20571
Author: Fabian Hueske <fh...@apache.org>
Date: 2017-02-15T14:25:01Z
[hotfix] [core] Add missing @PublicEvolving annotations to classes in flink-core.
commit 3e61eaabf0377c4aa459e3dbe0a29a74c07f352c
Author: Fabian Hueske <fh...@apache.org>
Date: 2017-02-15T14:25:15Z
[hotfix] [core] Add missing @Internal annotations to classes in flink-core.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3323: [hotfix] [core] Add missing stability annotations ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3323#discussion_r102923999
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/Archiveable.java ---
@@ -17,8 +17,11 @@
*/
package org.apache.flink.api.common;
+import org.apache.flink.annotation.PublicEvolving;
+
import java.io.Serializable;
+@PublicEvolving
--- End diff --
Thanks @zentol
the PR got already merged. Will do a hotfix patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3323: [hotfix] [core] Add missing stability annotations ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3323#discussion_r102227190
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/Archiveable.java ---
@@ -17,8 +17,11 @@
*/
package org.apache.flink.api.common;
+import org.apache.flink.annotation.PublicEvolving;
+
import java.io.Serializable;
+@PublicEvolving
--- End diff --
This should be internal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3323: [hotfix] [core] Add missing stability annotations for cla...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3323
Good cleanup, thanks a lot!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3323: [hotfix] [core] Add missing stability annotations ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/3323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---