You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/08/26 16:21:37 UTC
Review Request 51461: GEODE-1803 Inefficient code in
ClientMetadataService.getServerToFilterMap()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/
-----------------------------------------------------------
Review request for geode and Hitesh Khamesra.
Bugs: GEODE-1803
https://issues.apache.org/jira/browse/GEODE-1803
Repository: geode
Description
-------
avoid using Collections.shuffle() to find a random server location
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java d3b0cf3204b2d295b362544425a3f08a83090974
Diff: https://reviews.apache.org/r/51461/diff/
Testing
-------
precheckin
Thanks,
Bruce Schuchardt
Re: Review Request 51461: GEODE-1803 Inefficient code in
ClientMetadataService.getServerToFilterMap()
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146975
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java (line 120)
<https://reviews.apache.org/r/51461/#comment213915>
I'm going to change this to use the new "random" instance variable.
- Bruce Schuchardt
On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2016, 4:21 p.m.)
>
>
> Review request for geode and Hitesh Khamesra.
>
>
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
>
>
> Repository: geode
>
>
> Description
> -------
>
> avoid using Collections.shuffle() to find a random server location
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java d3b0cf3204b2d295b362544425a3f08a83090974
>
> Diff: https://reviews.apache.org/r/51461/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 51461: GEODE-1803 Inefficient code in
ClientMetadataService.getServerToFilterMap()
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146978
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2016, 4:21 p.m.)
>
>
> Review request for geode and Hitesh Khamesra.
>
>
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
>
>
> Repository: geode
>
>
> Description
> -------
>
> avoid using Collections.shuffle() to find a random server location
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java d3b0cf3204b2d295b362544425a3f08a83090974
>
> Diff: https://reviews.apache.org/r/51461/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 51461: GEODE-1803 Inefficient code in
ClientMetadataService.getServerToFilterMap()
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146976
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java (line 120)
<https://reviews.apache.org/r/51461/#comment213916>
Nice catch Bruce.
- Hitesh Khamesra
On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2016, 4:21 p.m.)
>
>
> Review request for geode and Hitesh Khamesra.
>
>
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
>
>
> Repository: geode
>
>
> Description
> -------
>
> avoid using Collections.shuffle() to find a random server location
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java d3b0cf3204b2d295b362544425a3f08a83090974
>
> Diff: https://reviews.apache.org/r/51461/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>