You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org> on 2010/02/03 17:41:27 UTC
[jira] Created: (PIG-1217) [piggybank] evaluation.util.Top is
broken
[piggybank] evaluation.util.Top is broken
-----------------------------------------
Key: PIG-1217
URL: https://issues.apache.org/jira/browse/PIG-1217
Project: Pig
Issue Type: Bug
Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
Reporter: Dmitriy V. Ryaboy
Assignee: Dmitriy V. Ryaboy
Priority: Minor
Fix For: 0.7.0
Attachments: fix_top_udf.diff
The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Patch Available (was: Open)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829589#action_12829589 ]
Dmitriy V. Ryaboy commented on PIG-1217:
----------------------------------------
The test failures appear to be unrelated to this change. Please review.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: fix_top_udf-pig0.5.diff
Attaching a version for pig 0.5
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf-pig0.5.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832334#action_12832334 ]
Alan Gates commented on PIG-1217:
---------------------------------
When I ran the piggybank tests with this patch I got:
{code}
Testsuite: org.apache.pig.piggybank.test.evaluation.util.TestTop
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 0.044 sec
Testcase: testTopExec took 0.017 sec
Testcase: testTopAlgebraic took 0.006 sec
FAILED
Value 0 exceeded the expected limit
junit.framework.AssertionFailedError: Value 0 exceeded the expected limit
at org.apache.pig.piggybank.test.evaluation.util.TestTop.checkItemsGT(Unknown Source)
at org.apache.pig.piggybank.test.evaluation.util.TestTop.testTopAlgebraic(Unknown Source)
{code}
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: fix_top_udf.diff
Simplified Initial per Alan's comments (just returning the tuple doesn't work, btw).
Also made it a bit safer around nulls.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-1217:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Removed line 72 of the test per Dmitriy request. With that change, tests went fine. Patch checked in.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829811#action_12829811 ]
Hadoop QA commented on PIG-1217:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12434839/fix_top_udf.diff
against trunk revision 906326.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/200/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/200/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/200/console
This message is automatically generated.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Open (was: Patch Available)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: fix_top_udf.diff
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: fix_top_udf.diff
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Open (was: Patch Available)
Huh. I wonder what Hudson tested -- I accidentally attached an old version of the unit test, which doesn't even compile with the new Top. But Hudson passed contrib tests, and managed to fail on core tests.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Patch Available (was: Open)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1217) [piggybank] evaluation.util.Top is broken
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1217.
---------------------------
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: (was: fix_top_udf.diff)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: (was: fix_top_udf-pig0.5.diff)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829137#action_12829137 ]
Dmitriy V. Ryaboy commented on PIG-1217:
----------------------------------------
Attached patch fixes the issue.
While I was in there, I also made it algebraic, and reduced the amount of reflection this function required (it used to call instanceof twice for every comparison operation, several of which may be needed for every tuple).
This patch should apply to 0.6 as well.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Patch Available (was: Open)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Patch Available (was: Open)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829694#action_12829694 ]
Dmitriy V. Ryaboy commented on PIG-1217:
----------------------------------------
I see, thanks for the tip. How does this work with tuple reuse -- can I just return the input tuple, or do I need to copy the contents to a new tuple in Top.Initial() ?
No worries about 0.6, I'd rather it finally go out than try to get something like this in at the last moment.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829265#action_12829265 ]
Hadoop QA commented on PIG-1217:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12434689/fix_top_udf.diff
against trunk revision 905377.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/189/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/189/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/189/console
This message is automatically generated.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf-pig0.5.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829688#action_12829688 ]
Alan Gates commented on PIG-1217:
---------------------------------
In general, looks good. A comment on Top.Initial. If you do something like
B = group A ...
C = foreach B generate myudf(A);
and myudf is algebraic, you are guaranteed to only get one record at a time in the Initial function because Pig doesn't do any collecting of the keys. That is, even if ten records in a row have the same key Pig won't detect that and collate them into the bag before calling Initial. We take advantage of that in a number of the built in functions (eg COUNT) to make the processing of Initial easier. You may want to do the same here.
As far as getting it into 0.6 release, I think Olga was trying to roll the package today or tomorrow, so we may be out of time.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832343#action_12832343 ]
Dmitriy V. Ryaboy commented on PIG-1217:
----------------------------------------
Oops, right, that check is actually no longer valid based on what you said about how the data gets fed into Initial.
Can you delete line 72 of TestTop and rerun?
Or I can repost a patch.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Status: Open (was: Patch Available)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1217:
-----------------------------------
Attachment: fix_top_udf.diff
a patch that actually works :-)
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831940#action_12831940 ]
Hadoop QA commented on PIG-1217:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435416/fix_top_udf.diff
against trunk revision 908324.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/207/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/207/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/207/console
This message is automatically generated.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff, fix_top_udf.diff, fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is
broken
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829557#action_12829557 ]
Hadoop QA commented on PIG-1217:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12434746/fix_top_udf.diff
against trunk revision 906326.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/198/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/198/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/198/console
This message is automatically generated.
> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
> Key: PIG-1217
> URL: https://issues.apache.org/jira/browse/PIG-1217
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.