You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/01/23 23:49:31 UTC

[3/3] commons-rng git commit: Minor fixes (CheckStyle, FindBugs).

Minor fixes (CheckStyle, FindBugs).


Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/31045880
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/31045880
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/31045880

Branch: refs/heads/master
Commit: 31045880c65570d0fc4ef132f6b3959f1ce20d6a
Parents: 8714ca7
Author: Gilles <er...@apache.org>
Authored: Wed Jan 24 00:48:27 2018 +0100
Committer: Gilles <er...@apache.org>
Committed: Wed Jan 24 00:48:27 2018 +0100

----------------------------------------------------------------------
 .../commons/rng/jmh/distribution/NextGaussianPerformance.java      | 2 +-
 .../apache/commons/rng/jmh/distribution/SamplersPerformance.java   | 2 +-
 .../distribution/AhrensDieterMarsagliaTsangGammaSampler.java       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rng/blob/31045880/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/NextGaussianPerformance.java
----------------------------------------------------------------------
diff --git a/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/NextGaussianPerformance.java b/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/NextGaussianPerformance.java
index 21c4b39..018ded8 100644
--- a/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/NextGaussianPerformance.java
+++ b/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/NextGaussianPerformance.java
@@ -42,7 +42,7 @@ import java.util.Random;
 @Fork(value = 1, jvmArgs = {"-server", "-Xms128M", "-Xmx128M"})
 public class NextGaussianPerformance {
     /** Number of samples per run. */
-    private final int NUM_SAMPLES = 10000000;
+    private static final int NUM_SAMPLES = 10000000;
     /** JDK's generator. */
     private final Random random = new Random();
     /**

http://git-wip-us.apache.org/repos/asf/commons-rng/blob/31045880/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/SamplersPerformance.java
----------------------------------------------------------------------
diff --git a/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/SamplersPerformance.java b/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/SamplersPerformance.java
index 37ca30a..b438b57 100644
--- a/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/SamplersPerformance.java
+++ b/commons-rng-jmh/src/main/java/org/apache/commons/rng/jmh/distribution/SamplersPerformance.java
@@ -59,7 +59,7 @@ import org.apache.commons.rng.sampling.distribution.PoissonSampler;
 @Fork(value = 1, jvmArgs = {"-server", "-Xms128M", "-Xmx128M"})
 public class SamplersPerformance {
     /** Number of samples per run. */
-    private final int NUM_SAMPLES = 10000000;
+    private static final int NUM_SAMPLES = 10000000;
 
     /**
      * The benchmark state (retrieve the various "RandomSource"s).

http://git-wip-us.apache.org/repos/asf/commons-rng/blob/31045880/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/AhrensDieterMarsagliaTsangGammaSampler.java
----------------------------------------------------------------------
diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/AhrensDieterMarsagliaTsangGammaSampler.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/AhrensDieterMarsagliaTsangGammaSampler.java
index 7a41197..cbe327c 100644
--- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/AhrensDieterMarsagliaTsangGammaSampler.java
+++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/AhrensDieterMarsagliaTsangGammaSampler.java
@@ -117,7 +117,7 @@ public class AhrensDieterMarsagliaTsangGammaSampler
         } else {
             while (true) {
                 final double x = gaussian.sample();
-                final double oPcTx = (1 + cOptim * x);
+                final double oPcTx = 1 + cOptim * x;
                 final double v = oPcTx * oPcTx * oPcTx;
 
                 if (v <= 0) {