You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by jaoki <gi...@git.apache.org> on 2015/12/08 23:50:53 UTC
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
GitHub user jaoki opened a pull request:
https://github.com/apache/flink/pull/1444
[FLINK-3116] Remove RecordOperator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaoki/flink Remove-RecordOperator-FLINK-3116
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1444
----
commit ce98180d5de71bcfb99264ada525b7ba8c9f9b52
Author: Jun Aoki <ja...@apache.org>
Date: 2015-12-08T22:49:41Z
[FLINK-3116] Remove RecordOperator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1444#issuecomment-166330470
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1444#issuecomment-163052369
Looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by jaoki <gi...@git.apache.org>.
Github user jaoki commented on the pull request:
https://github.com/apache/flink/pull/1444#issuecomment-163438135
The travis error is in streaming-java, but my change was made in core and optimizer
```
[INFO] flink-runtime-web .................................. SUCCESS [ 16.675 s]
[INFO] flink-streaming-java ............................... FAILURE [01:57 min]
[INFO] flink-examples ..................................... SKIPPED
```
and error seems to relate to some jar file?
```
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :flink-streaming-java
Trying to KILL watchdog (2290).
./tools/travis_mvn_watchdog.sh: line 204: 2290 Terminated watchdog
MVN exited with EXIT CODE: 1.
java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar (No such file or directory)
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:220)
at java.util.zip.ZipFile.<init>(ZipFile.java:150)
at java.util.zip.ZipFile.<init>(ZipFile.java:121)
at sun.tools.jar.Main.list(Main.java:1060)
at sun.tools.jar.Main.run(Main.java:291)
at sun.tools.jar.Main.main(Main.java:1233)
find: `./flink-yarn-tests/target/flink-yarn-tests*': No such file or directory
PRODUCED build artifacts.
1.log 2.log build_info mvn.out
The command "./tools/travis_mvn_watchdog.sh 300" exited with 1.
```
Most probably it is irrelevant from my change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1444#issuecomment-164401809
Thanks for your contribution!
I will merge this PR in the next set of cleanups that remove the remaining Record code...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1444#issuecomment-163052881
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---