You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/19 08:10:28 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4270: bug fix

wu-sheng commented on a change in pull request #4270: bug fix
URL: https://github.com/apache/skywalking/pull/4270#discussion_r368274228
 
 

 ##########
 File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/parser/listener/endpoint/MultiScopesSpanListener.java
 ##########
 @@ -211,6 +212,9 @@ public void parseEntry(SpanDecorator spanDecorator, SegmentCoreInfo segmentCoreI
     }
 
     private void setPublicAttrs(SourceBuilder sourceBuilder, SpanDecorator spanDecorator) {
+        if(Objects.isNull(endpointInventoryCache)){
 
 Review comment:
   The `endpointInventoryCache` is initialized in the constructor, why null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services