[GitHub] [zookeeper] symat commented on issue #1074: ZOOKEEPER-3530 Include compiled C-client in the binary tarball

[GitBox <gi...@apache.org>]

symat commented on issue #1074: ZOOKEEPER-3530 Include compiled C-client in the binary tarball
URL: https://github.com/apache/zookeeper/pull/1074#issuecomment-527344162
 
 
   I think the consistent behaviour would be that when -Pfull-build is not present, then there should be no C-client binary in the tarball.
   
   After adding this patch to the top of your current patch in ZOOKEEPER-3436, I got the following:
   
   output of the `mvn clean -Pfull-build && mvn install -Pfull-build -Dskip-tests`:
   ```
   bin
     |--- ...
   conf
     |--- ...
   lib
     |--- ...
   usr
     |--- bin
            |--- cli_mt
            |--- cli_st
            |--- load_gen
     |--- include
            |--- zookeeper
                   |--- proto.h
                   |--- recordio.h
                   |--- zookeeper.h
                   |--- zookeeper.jute.h
                   |--- zookeeper_log.h
                   |--- zookeeper_version.h
     |--- lib
            |--- libzookeeper_mt.a
            |--- libzookeeper_mt.la
            |--- libzookeeper_mt.so
            |--- libzookeeper_mt.so.2
            |--- libzookeeper_mt.so.2.0.0
            |--- libzookeeper_st.a
            |--- libzookeeper_st.la
            |--- libzookeeper_st.so
            |--- libzookeeper_st.so.2
            |--- libzookeeper_st.so.2.0.0
   LICENSE.txt
   NOTICE.txt
   README.md
   README_packaging.txt
   ```
   
   and the output of the `mvn clean -Pfull-build && mvn install -Dskip-tests`:
   ```
   bin
     |--- ...
   conf
     |--- ...
   lib
     |--- ...
   LICENSE.txt
   NOTICE.txt
   README.md
   README_packaging.txt
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services