You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiang Yang (Code Review)" <ge...@cloudera.org> on 2024/10/30 15:47:33 UTC
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21994
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
IMPALA-13064: Install service for linux packaging.
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 214 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21994/1
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 06:48:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python2 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with virtualenv installed.
http://gerrit.cloudera.org:8080/#/c/21994/1/package/bin/impala.sh
File package/bin/impala.sh:
http://gerrit.cloudera.org:8080/#/c/21994/1/package/bin/impala.sh@78
PS1, Line 78: rm -f ${service_pidfile} && echo "(${i}/${counts}) ${service} is stopped." && return 0
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 15:50:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
Patch Set 2:
(3 comments)
Thanks for working on this! I just have some minor comments.
http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-13064: Install service for linux packaging.
nit: remove one space before "Install" and remove period at the end
http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt
File package/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt@89
PS2, Line 89: WORLD_EXECUTE)
IIUC, this means the permission is 777 which is too weak. Can we remove GROUP_WRITE and WORLD_WRITE?
http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd
File package/etc/init.d/catalogd:
http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd@35
PS2, Line 35: /bin/sh
Is there a reason to use "sh"? I think we use "bash" in impala.sh
https://github.com/apache/impala/blob/fe3f82179fa0726af0645d01f90a2bf966175b75/package/bin/impala.sh#L1
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Nov 2024 01:18:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 3:
(3 comments)
> Patch Set 2:
>
> (3 comments)
>
> Thanks for working on this! I just have some minor comments.
all done, Thanks quanlong!
http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-13064: Install service for linux packaging
> nit: remove one space before "Install" and remove period at the end
Done
http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt
File package/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt@89
PS2, Line 89: WORLD_EXECUTE)
> IIUC, this means the permission is 777 which is too weak. Can we remove GRO
Done
http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd
File package/etc/init.d/catalogd:
http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd@35
PS2, Line 35: /bin/sh
> Is there a reason to use "sh"? I think we use "bash" in impala.sh
Done
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Nov 2024 14:49:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17323/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2024 13:31:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
LGTM. Thanks for adding this missing part!
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst
File package/postinst:
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst@25
PS4, Line 25: id -u ${IMPALA_USER} &> /dev/null || useradd -g ${IMPALA_GROUP} ${IMPALA_USER}
> oops, I can't remeber why use '-G' option here, and I found use '-g' is eno
Ack
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 01:18:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21994
to look at the new patch set (#2).
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
IMPALA-13064: Install service for linux packaging.
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 216 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21994/2
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21994
to look at the new patch set (#3).
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
IMPALA-13064: Install service for linux packaging
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 216 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21994/3
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17308/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 16:13:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 4:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst
File package/postinst:
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst@25
PS4, Line 25: id -u ${IMPALA_USER} &> /dev/null || useradd -g ${IMPALA_GROUP} ${IMPALA_USER}
> Tried install the RPM on CentOS7 and saw this failure:
oops, I can't remeber why use '-G' option here, and I found use '-g' is enough.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 16:21:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11214/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 01:19:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 01:19:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst
File package/postinst:
http://gerrit.cloudera.org:8080/#/c/21994/4/package/postinst@25
PS4, Line 25: id -u ${IMPALA_USER} &> /dev/null || useradd -G ${IMPALA_GROUP} ${IMPALA_USER}
Tried install the RPM on CentOS7 and saw this failure:
useradd: group impala exists - if you want to add this user to that group, use -g.
warning: %post(impala-4.5.0_SNAPSHOT-1.x86_64) scriptlet failed, exit status 9
Non-fatal POSTIN scriptlet failure in rpm package impala-4.5.0_SNAPSHOT-1.x86_64
We need an additional -N option to avoid useradd creating the group.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 08:54:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21994
to look at the new patch set (#4).
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
IMPALA-13064: Install service for linux packaging
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 214 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21994/4
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17495/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 13:39:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21994
to look at the new patch set (#5).
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
IMPALA-13064: Install service for linux packaging
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 214 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21994/5
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17697/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 16:42:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13064: Install service for linux packaging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging
......................................................................
IMPALA-13064: Install service for linux packaging
This patch provides LSB-compliant init scripts for impala package,
administrator can manage impala services by the following commands:
'service <impala_service> <start|stop|restart|status|force-reload'
This patch also change the owner of package files to 'impala', and
launch process by the same user.
Testing:
- Manually deploy package on Ubuntu22.04 and verify it.
Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Reviewed-on: http://gerrit.cloudera.org:8080/21994
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M package/CMakeLists.txt
M package/bin/impala.sh
A package/etc/init.d/admissiond
A package/etc/init.d/catalogd
A package/etc/init.d/impalad
A package/etc/init.d/statestored
A package/postinst
7 files changed, 214 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe
Gerrit-Change-Number: 21994
Gerrit-PatchSet: 7
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>