You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Phil Sorber (JIRA)" <ji...@apache.org> on 2015/11/02 05:27:27 UTC
[jira] [Comment Edited] (TS-3883) ats_madvise() has no effect on
Linux (including MADV_DONTDUMP)
[ https://issues.apache.org/jira/browse/TS-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984730#comment-14984730 ]
Phil Sorber edited comment on TS-3883 at 11/2/15 4:26 AM:
----------------------------------------------------------
[~zwoop] asked me to add this to this ticket.
{noformat}
git cherry-pick 21a692ba242edb32916817535b82621a1aee8e0d 0bae26a9 e56d1f9eb6f55b0257d1fb758b773dea468159ee 471b969
{noformat}
These 4 commits lead to a "clean" back port of this patch, however it would be trivial to back port just the one commit related to this issue.
was (Author: psudaemon):
Leif asked me to add this to this ticket.
{noformat}
git cherry-pick 21a692ba242edb32916817535b82621a1aee8e0d 0bae26a9 e56d1f9eb6f55b0257d1fb758b773dea468159ee 471b969
{noformat}
These 4 commits lead to a "clean" back port of this patch, however it would be trivial to back port just the one commit related to this issue.
> ats_madvise() has no effect on Linux (including MADV_DONTDUMP)
> --------------------------------------------------------------
>
> Key: TS-3883
> URL: https://issues.apache.org/jira/browse/TS-3883
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Gancho Tenev
> Assignee: Phil Sorber
> Labels: A
> Fix For: 6.1.0
>
>
> While investigating unrelated issue with truncated core dumps on Linux, noticed that we run out of space on a few machines because of huge core dumps which were tending to the ATS process virtual memory size (reported by /proc/<pid>/status:VmSize on Linux).
> It looked like MADV_DONTDUMP memory use advice was not set properly.
> Further debugging showed that we have the following code in ats_madvise():
> {code}
> #if defined(linux)
> (void)addr;
> (void)len;
> (void)flags;
> return 0;
> #else . . .
> {code}
> Which would lead ats_madvise() to have no effect when "defined(linux)" is true, and would skip the necessary madvise() call to set MADV_DONTDUMP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)