[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6698: fix: parser for negative intervals

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6698:
URL: https://github.com/apache/arrow-datafusion/pull/6698#discussion_r1233237463


##########
datafusion/core/tests/sqllogictests/test_files/interval.slt:
##########
@@ -190,25 +190,25 @@ select interval '1 year' - '1 month' - '1 day' - '1 hour' - '1 minute' - '1 seco
 query ?
 select -interval '5' - '1' - '2' year;
 ----
-0 years -24 mons 0 days 0 hours 0 mins 0.000000000 secs
+0 years -96 mons 0 days 0 hours 0 mins 0.000000000 secs

Review Comment:
   Agree with you, I think we should notice this point. cc @alamb .
   If we will merge this PR, I think we need to add a ticket to follow this problem
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org