You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by nragon <gi...@git.apache.org> on 2017/03/16 10:37:01 UTC
[GitHub] flink pull request #3554: Detached (Remote)StreamEnvironment execution
GitHub user nragon opened a pull request:
https://github.com/apache/flink/pull/3554
Detached (Remote)StreamEnvironment execution
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nragon/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3554
----
commit 14592e6d3c1217537ed85c86cbebe168f5f05dcc
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:32:54Z
Update Flip6LocalStreamEnvironment.java
commit a3830b8b044cd9b4a0cb1455cd71d50e5b79b438
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:33:12Z
Update LocalStreamEnvironment.java
commit 1712b19b4126aea18742b6c6489486f13e9ee3e4
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:33:31Z
Update RemoteStreamEnvironment.java
commit 690969c0bc4fd2ac5828cff01d621f86e48de4d1
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:33:45Z
Update StreamContextEnvironment.java
commit 143a712df865c7c2de9137f1199c0723a4419e23
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:34:01Z
Update StreamExecutionEnvironment.java
commit 15a245e1fbd8c60d019677818aa6e4dd4a4ca0cb
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:34:18Z
Update StreamPlanEnvironment.java
commit 2753c5ba17fd4e91036b5d5b2f806b39763b8232
Author: nragon <nu...@hotmail.com>
Date: 2017-03-16T10:35:59Z
Update Flip6LocalStreamEnvironment.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3554: Detached (Remote)StreamEnvironment execution
Posted by nragon <gi...@git.apache.org>.
Github user nragon commented on the issue:
https://github.com/apache/flink/pull/3554
I guess for backward compatibility this last commig would do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3554: Detached (Remote)StreamEnvironment execution
Posted by bachrc <gi...@git.apache.org>.
Github user bachrc commented on the issue:
https://github.com/apache/flink/pull/3554
Why isn't it implemented yet ? Expect the conflicting files, it's still not possible to launch a flink job in a detached mode.
---
[GitHub] flink pull request #3554: Detached (Remote)StreamEnvironment execution
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3554#discussion_r106431288
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java ---
@@ -1498,10 +1499,12 @@ public JobExecutionResult execute() throws Exception {
*
* @param jobName
* Desired name of the job
+ * @param detached
+ * Whether to run the job in detached mode
* @return The result of the job execution, containing elapsed time and accumulators.
* @throws Exception which occurs during job execution.
*/
- public abstract JobExecutionResult execute(String jobName) throws Exception;
+ public abstract JobExecutionResult execute(String jobName, boolean detached) throws Exception;
--- End diff --
this is a public method that you mustn't change; you have to add a completely new method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3554: Detached (Remote)StreamEnvironment execution
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3554#discussion_r123901226
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java ---
@@ -25,229 +25,205 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.common.InvalidProgramException;
import org.apache.flink.api.common.JobExecutionResult;
+import org.apache.flink.api.common.JobSubmissionResult;
import org.apache.flink.api.java.ExecutionEnvironment;
import org.apache.flink.client.program.ClusterClient;
import org.apache.flink.client.program.JobWithJars;
import org.apache.flink.client.program.ProgramInvocationException;
import org.apache.flink.client.program.StandaloneClusterClient;
import org.apache.flink.configuration.ConfigConstants;
import org.apache.flink.configuration.Configuration;
-
import org.apache.flink.streaming.api.graph.StreamGraph;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@Public
public class RemoteStreamEnvironment extends StreamExecutionEnvironment {
-
- private static final Logger LOG = LoggerFactory.getLogger(RemoteStreamEnvironment.class);
-
- /** The hostname of the JobManager */
- private final String host;
-
- /** The port of the JobManager main actor system */
--- End diff --
please revert the auto-formatting here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---