You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by fp...@apache.org on 2014/11/19 23:36:57 UTC

svn commit: r1640635 - in /zookeeper/trunk: CHANGES.txt src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java

Author: fpj
Date: Wed Nov 19 22:36:57 2014
New Revision: 1640635

URL: http://svn.apache.org/r1640635
Log:
ZOOKEEPER-2060 Trace bug in NettyServerCnxnFactory (Ian via fpj)


Modified:
    zookeeper/trunk/CHANGES.txt
    zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java

Modified: zookeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/trunk/CHANGES.txt?rev=1640635&r1=1640634&r2=1640635&view=diff
==============================================================================
--- zookeeper/trunk/CHANGES.txt (original)
+++ zookeeper/trunk/CHANGES.txt Wed Nov 19 22:36:57 2014
@@ -37,6 +37,8 @@ IMPROVEMENTS:
   ZOOKEEPER-2079 Stop daemon with "kill" rather than "kill -9" (Guillaume ALAUX
   via michim)
 
+  ZOOKEEPER-2060 Trace bug in NettyServerCnxnFactory (Ian via fpj)
+
 Release 3.5.0 - 8/4/2014
 
 NEW FEATURES:

Modified: zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java
URL: http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java?rev=1640635&r1=1640634&r2=1640635&view=diff
==============================================================================
--- zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java (original)
+++ zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java Wed Nov 19 22:36:57 2014
@@ -183,9 +183,11 @@ public class NettyServerCnxnFactory exte
                         cnxn.queuedBuffer = dynamicBuffer(buf.readableBytes());
                     }
                     cnxn.queuedBuffer.writeBytes(buf);
-                    LOG.debug(Long.toHexString(cnxn.sessionId)
-                            + " queuedBuffer 0x"
-                            + ChannelBuffers.hexDump(cnxn.queuedBuffer));
+                    if (LOG.isTraceEnabled()) {
+                        LOG.trace(Long.toHexString(cnxn.sessionId)
+                                + " queuedBuffer 0x"
+                                + ChannelBuffers.hexDump(cnxn.queuedBuffer));
+                    }
                 } else {
                     LOG.debug("not throttled");
                     if (cnxn.queuedBuffer != null) {