You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/01/18 01:39:35 UTC
[GitHub] incubator-quickstep pull request #163: Marked LIP as a non-default argument.
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/163
Marked LIP as a non-default argument.
Assigned to @jianqiao.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep lip-nullptr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit ffe183b57dada6e862128e5326ec1ff492d7af93
Author: Zuyu Zhang <zu...@apache.org>
Date: 2017-01-18T01:38:50Z
Marked LIP as a non-default argument.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #163: Marked LIP as a non-default argument.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #163: Marked LIP as a non-default argument.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/163
@jianqiao First, it is doable. Second, I will add a argument with default value, without worrying about the argument order in terms of coding style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #163: Marked LIP as a non-default argument.
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/163
LGTM. Is there some special reason for doing this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---