You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/02 10:46:39 UTC
[GitHub] NicoK commented on a change in pull request #6992: [FLINK-10747]
Update SingleInputGate#requestedPartitionsFlag under lock
NicoK commented on a change in pull request #6992: [FLINK-10747] Update SingleInputGate#requestedPartitionsFlag under lock
URL: https://github.com/apache/flink/pull/6992#discussion_r230332580
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -482,23 +482,25 @@ public void requestPartitions() throws IOException, InterruptedException {
}
synchronized (requestLock) {
- if (isReleased) {
- throw new IllegalStateException("Already released.");
- }
+ if (!requestedPartitionsFlag) {
Review comment:
we should follow the same "having the shorter/simpler branch first" approach as before (also see https://github.com/apache/flink/pull/6974#discussion_r229666072 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services