You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2022/11/21 18:20:24 UTC
[pinot] branch master updated: have query table list show search bar; fix InstancesTables filter (#9742)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1491f34471 have query table list show search bar; fix InstancesTables filter (#9742)
1491f34471 is described below
commit 1491f34471c95d85407123f0b152874095e3ae41
Author: Johan Adami <47...@users.noreply.github.com>
AuthorDate: Mon Nov 21 13:20:18 2022 -0500
have query table list show search bar; fix InstancesTables filter (#9742)
---
.../app/components/Homepage/InstancesTables.tsx | 25 ++++++++++++++--------
.../app/components/Query/QuerySideBar.tsx | 4 ++--
2 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx b/pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx
index a0e32720d1..733beb7357 100644
--- a/pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx
+++ b/pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx
@@ -17,23 +17,30 @@
* under the License.
*/
-import React, { } from 'react';
-import map from 'lodash/map';
+import React from 'react';
import get from 'lodash/get';
+import has from 'lodash/has';
import InstanceTable from './InstanceTable';
-const Instances = ({instances, clusterName}) => {
+const Instances = ({ instances, clusterName }) => {
const order = ['Controller', 'Broker', 'Server', 'Minion'];
return (
<>
- {
- map(order, (key) => {
+ {order
+ .filter((key) => has(instances, key))
+ .map((key) => {
const value = get(instances, key, []);
- return <InstanceTable key={key} name={`${key}s`} instances={value} clusterName={clusterName} />;
- })
- }
+ return (
+ <InstanceTable
+ key={key}
+ name={`${key}s`}
+ instances={value}
+ clusterName={clusterName}
+ />
+ );
+ })}
</>
);
};
-export default Instances;
\ No newline at end of file
+export default Instances;
diff --git a/pinot-controller/src/main/resources/app/components/Query/QuerySideBar.tsx b/pinot-controller/src/main/resources/app/components/Query/QuerySideBar.tsx
index 6da726db10..d886d3b128 100644
--- a/pinot-controller/src/main/resources/app/components/Query/QuerySideBar.tsx
+++ b/pinot-controller/src/main/resources/app/components/Query/QuerySideBar.tsx
@@ -100,7 +100,7 @@ const Sidebar = ({ tableList, fetchSQLData, tableSchema, selectedTable, queryLoa
data={tableList}
cellClickCallback={fetchSQLData}
isCellClickable
- showSearchBox={false}
+ showSearchBox={true}
/>
{!queryLoader && tableSchema.records.length ? (
@@ -108,7 +108,7 @@ const Sidebar = ({ tableList, fetchSQLData, tableSchema, selectedTable, queryLoa
title={`${selectedTable} schema`}
data={tableSchema}
highlightBackground
- showSearchBox={false}
+ showSearchBox={true}
/>
) : null}
</Grid>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org