You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/28 19:45:01 UTC

[GitHub] [arrow-rs] Jefffrey commented on a diff in pull request #3209: Infer timestamps from CSV files

Jefffrey commented on code in PR #3209:
URL: https://github.com/apache/arrow-rs/pull/3209#discussion_r1033981345


##########
arrow-csv/src/reader.rs:
##########
@@ -90,10 +92,12 @@ fn infer_field_schema(string: &str, datetime_re: Option<Regex>) -> DataType {
         DataType::Float64
     } else if INTEGER_RE.is_match(string) {
         DataType::Int64
-    } else if datetime_re.is_match(string) {
-        DataType::Date64
-    } else if DATE_RE.is_match(string) {
+    } else if DATE32_RE.is_match(string) {

Review Comment:
   Ah didn't know about RegexSet, I can give it a shot in this PR a bit later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org