You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 04:21:16 UTC

[PR] fix: distinguish untested metrics sources [rocketmq-dashboard]

Aias00 opened a new pull request, #1966:
URL: https://github.com/apache/rocketmq-dashboard/pull/1966

   ## Summary
   
   - align the frontend data source type with the backend contract where status is optional
   - render missing or unknown health state as Not tested instead of falling back to Offline
   - preserve existing badges for known health states
   - cover the real status-less API response shape with a focused page regression test
   
   Closes #1965
   
   ## Track
   
   Track 1 / Metrics data source management.
   
   ## Validation
   
   - npm test -- --run src/pages/settings/__tests__ (2 files, 9 tests passed)
   - npm test -- --run src/pages/settings/__tests__/DataSourceTab.test.tsx src/api/settings.test.ts src/components/__tests__/StatusBadge.test.tsx (3 files, 20 tests passed)
   - npm run build
   - npx eslint src/api/settings.ts src/i18n/translations.ts src/pages/settings/index.tsx src/pages/settings/__tests__/DataSourceTab.test.tsx
   - git diff --check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: harden metrics data source lifecycle [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1966:
URL: https://github.com/apache/rocketmq-dashboard/pull/1966#issuecomment-5267069949

   @lizhimins This consolidated Track 1 metrics data-source PR is ready for review: the branch is CLEAN and Backend Build, Frontend Build, and Frontend Docker Build are all green. Together with #1908, it completes #1765; this PR carries the actionable metrics error handling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: harden metrics data source lifecycle [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1966:
URL: https://github.com/apache/rocketmq-dashboard/pull/1966


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org