You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/25 07:54:23 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #15638: [fix] Ensure resources are disposed in a sync way while closing ManagedLedgerFactory and MetadataStore

lhotari commented on code in PR #15638:
URL: https://github.com/apache/pulsar/pull/15638#discussion_r881336111


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStore.java:
##########
@@ -159,4 +159,10 @@ public interface MetadataStore extends AutoCloseable {
      * @return the metadata cache object
      */
     <T> MetadataCache<T> getMetadataCache(MetadataSerde<T> serde);
+
+    /**
+     * Async close the current instance.
+     * @return
+     */
+    CompletableFuture<Void> closeAsync();

Review Comment:
   Changing the MetadataStore interface would require a PIP. We cannot do that. Please revert this part of the changes. It will also resolve the unclosed metadata store threads issue seen in the thread dumps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org