You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/11 06:59:49 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
kaijchen opened a new pull request, #3402:
URL: https://github.com/apache/ozone/pull/3402
## What changes were proposed in this pull request?
Tests migrated:
```
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/pipeline/TestListPipelinesSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestContainerBalancerSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestRecommissionSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestUsageInfoSubcommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestDecommissionSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestMaintenanceSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestListInfoSubcommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestReportSubCommand.java
./hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6730
## How was this patch tested?
```bash
$ mvn -pl :hdds-tools test
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestContainerBalancerSubCommand
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.608 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestContainerBalancerSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestDecommissionSubCommand
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.68 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestDecommissionSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestRecommissionSubCommand
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.673 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestRecommissionSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestUsageInfoSubcommand
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.918 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestUsageInfoSubcommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestMaintenanceSubCommand
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.702 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestMaintenanceSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.datanode.TestListInfoSubcommand
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 s - in org.apache.hadoop.hdds.scm.cli.datanode.TestListInfoSubcommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.container.TestInfoSubCommand
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.992 s - in org.apache.hadoop.hdds.scm.cli.container.TestInfoSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.container.TestReportSubCommand
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.838 s - in org.apache.hadoop.hdds.scm.cli.container.TestReportSubCommand
[INFO] Running org.apache.hadoop.hdds.scm.cli.pipeline.TestListPipelinesSubCommand
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 s - in org.apache.hadoop.hdds.scm.cli.pipeline.TestListPipelinesSubCommand
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.356 s
[INFO] Finished at: 2022-05-11T14:57:16+08:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3402:
URL: https://github.com/apache/ozone/pull/3402#issuecomment-1126180861
> Can you please explain why that is needed? These static imports make the code more concise and readable.
Some tests may include helper methods like `assertContains()`, this is for distinguish assertions from JUnit and the custom assertions. If you think this shouldn't be changed, I can revert it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3402:
URL: https://github.com/apache/ozone/pull/3402#issuecomment-1126240292
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3402:
URL: https://github.com/apache/ozone/pull/3402#issuecomment-1126626051
Thanks @adoroszlai and @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3402:
URL: https://github.com/apache/ozone/pull/3402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3402: HDDS-6730. Migrate tests in hdds-tools to JUnit5
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3402:
URL: https://github.com/apache/ozone/pull/3402#issuecomment-1126332440
Thanks @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org