You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/06 12:24:31 UTC
[GitHub] [incubator-doris] pengxiangyu opened a new pull request, #9418: Return error tablet list when close_wait return error
pengxiangyu opened a new pull request, #9418:
URL: https://github.com/apache/incubator-doris/pull/9418
# Proposed changes
Issue Number: close #9417
## Problem Summary:
In function close_wait() of delta_writer.cpp, if _flush_token->wait() return an error, it will not be returned to front.
Because in PInternalServiceImpl::tablet_writer_add_batch, _exec_env->load_channel_mgr()->add_batch(*request, response); will not return an error, but only return error_tablets. However error_tablets in close_wait() is not returned.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#issuecomment-1120112693
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#issuecomment-1120112689
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#discussion_r867288661
##########
be/src/olap/delta_writer.cpp:
##########
@@ -321,7 +322,13 @@ Status DeltaWriter::close_wait(google::protobuf::RepeatedPtrField<PTabletInfo>*
}
// return error if previous flush failed
- RETURN_NOT_OK(_flush_token->wait());
+ Status s = Status::OK();
Review Comment:
```suggestion
Status s = _flush_token->wait();
if (!s.ok()) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#issuecomment-1120116201
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#issuecomment-1120201835
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9418: [Bug] Missing error tablet list when close_wait return error
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org