You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2012/09/20 17:23:21 UTC
svn commit: r1388070 - in
/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3:
StringUtilsEqualsIndexOfTest.java builder/CompareToBuilderTest.java
builder/EqualsBuilderTest.java builder/HashCodeBuilderTest.java
Author: sebb
Date: Thu Sep 20 15:23:20 2012
New Revision: 1388070
URL: http://svn.apache.org/viewvc?rev=1388070&view=rev
Log:
Implement missing equals() methods
Modified:
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java?rev=1388070&r1=1388069&r2=1388070&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java Thu Sep 20 15:23:20 2012
@@ -497,6 +497,11 @@ public class StringUtilsEqualsIndexOfTes
}
@Override
+ public int hashCode() {
+ return seq.hashCode();
+ }
+
+ @Override
public String toString() {
return seq.toString();
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java?rev=1388070&r1=1388069&r2=1388070&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java Thu Sep 20 15:23:20 2012
@@ -49,6 +49,11 @@ public class CompareToBuilderTest {
return a == rhs.a;
}
+ @Override
+ public int hashCode() {
+ return a;
+ }
+
public void setA(int a) {
this.a = a;
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java?rev=1388070&r1=1388069&r2=1388070&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java Thu Sep 20 15:23:20 2012
@@ -53,6 +53,11 @@ public class EqualsBuilderTest {
return a == rhs.a;
}
+ @Override
+ public int hashCode() {
+ return a;
+ }
+
public void setA(int a) {
this.a = a;
}
@@ -83,6 +88,11 @@ public class EqualsBuilderTest {
return super.equals(o) && b == rhs.b;
}
+ @Override
+ public int hashCode() {
+ return b *17 + super.hashCode();
+ }
+
public void setB(int b) {
this.b = b;
}
@@ -948,6 +958,11 @@ public class EqualsBuilderTest {
return false;
}
+ @Override
+ public int hashCode() {
+ return a;
+ }
+
public int getA() {
return this.a;
}
@@ -974,6 +989,11 @@ public class EqualsBuilderTest {
return false;
}
+ @Override
+ public int hashCode() {
+ return b;
+ }
+
public int getB() {
return this.b;
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java?rev=1388070&r1=1388069&r2=1388070&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java Thu Sep 20 15:23:20 2012
@@ -83,6 +83,11 @@ public class HashCodeBuilderTest {
return a == rhs.a;
}
+ @Override
+ public int hashCode() {
+ return a;
+ }
+
public void setA(int a) {
this.a = a;
}
@@ -119,6 +124,12 @@ public class HashCodeBuilderTest {
TestSubObject rhs = (TestSubObject) o;
return super.equals(o) && b == rhs.b;
}
+
+ @Override
+ public int hashCode() {
+ return b*17 + t ;
+ }
+
}
@Test