[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6322: Core: Fix NPE in CloseableIterable.close()

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #6322:
URL: https://github.com/apache/iceberg/pull/6322#discussion_r1036232462


##########
api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java:
##########
@@ -201,6 +201,14 @@ public CloseableIterator<Integer> iterator() {
     Assertions.assertThat(counter.get()).isEqualTo(items.size());
   }
 
+  @Test
+  public void concatIterablesWithIterator() throws IOException {

Review Comment:
   nit: this method name can be more descriptive, sth like `testCloseWithEmptyIterables`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org