You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/09/22 12:47:41 UTC
[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/64
CB-8936 Tweaking windows log gathering timeout
https://issues.apache.org/jira/browse/CB-8936
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-8936
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 7a6cf285161ad632052f900c565a332bac8be13e
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2015-09-22T08:15:51Z
CB-8936 Tweaking windows log gathering timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/64#discussion_r40131491
--- Diff: medic/medic-log.js ---
@@ -63,10 +63,14 @@ function logIOS() {
});
}
-function logWindows() {
+function logWindows(timeout) {
var logScriptPath = path.join("mobilespec", "platforms", "windows", "cordova", "log.bat");
if (fs.existsSync(logScriptPath)) {
- shelljs.exec(logScriptPath + " --dump --mins 15", function (code, output) {
+ var mins = 15;
+ if (timeout) {
+ mins = Math.ceil(timeout / 60);
--- End diff --
A few notes:
- Please add a small constant (~2 min) to the time so that we also capture anything that happened before the run
- Please factor out the default 15 mins into a constant
- Please add a function to convert minutes to seconds, so it's easier to read (i.e. `mins = sec2min(timeout)`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/64#issuecomment-142696116
I misspelled "This closes #64"... sorry. This is merged and can be closed and pruned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-medic/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org