You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/02/08 00:58:37 UTC
[GitHub] [drill] dobesv opened a new pull request #1973: Fix typo in class
name of FormSecurityHandler
dobesv opened a new pull request #1973: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973
Just a little fix to the name of this class. It isn't referenced anywhere by name, so only the class file itself had to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on issue #1973: DRILL-7575: Fix typo
in class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on issue #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-585359000
@cgivre, please resolve Jira after its PR is merged (see the last point here: https://drill.apache.org/docs/apache-drill-contribution-guidelines/#step-3-get-your-code-reviewed-and-committed-to-the-project)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre edited a comment on issue #1973: DRILL-7575: Fix
typo in class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
cgivre edited a comment on issue #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-583848523
Last thing... can you please change the commit message to:
`DRILL-7575: Fix typo in class name of FormSecurityHandler`
LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] dobesv commented on issue #1973: Fix typo in class name of
FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
dobesv commented on issue #1973: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-583809505
@cgivre I think I made the requested changes, let me know if there's anything more needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on issue #1973: Fix typo in class name of
FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
cgivre commented on issue #1973: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-583792630
Thanks for the contribution! 3 things:
1. Could you please uncomment or remove the logger line?
2. Drill PRs must have a corresponding JIRA issue. Even though this is a minor fix, would you mind please creating a JIRA issue and adding that to the title of the PR?
3. Please add a blank line to the end of this file.
Other than that, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] dobesv commented on issue #1973: DRILL-7575: Fix typo in
class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
dobesv commented on issue #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-584238274
OK, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre merged pull request #1973: DRILL-7575: Fix typo in
class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on issue #1973: DRILL-7575: Fix typo in
class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
cgivre commented on issue #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-584256826
LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on issue #1973: DRILL-7575: Fix typo in
class name of FormSecurityHandler
Posted by GitBox <gi...@apache.org>.
cgivre commented on issue #1973: DRILL-7575: Fix typo in class name of FormSecurityHandler
URL: https://github.com/apache/drill/pull/1973#issuecomment-583848523
Last thing... can you please change the commit message to: "
`DRILL-7575: Fix typo in class name of FormSecurityHandler`
LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services