[GitHub] [hadoop-ozone] sodonnel opened a new pull request #309: HDDS-2593 - DatanodeAdminMonitor should track under replicated containers and complete the admin workflow accordingly

[GitBox <gi...@apache.org>]

sodonnel opened a new pull request #309: HDDS-2593 - DatanodeAdminMonitor should track under replicated containers and complete the admin workflow accordingly
URL: https://github.com/apache/hadoop-ozone/pull/309
 
 
   ## What changes were proposed in this pull request?
   
   This PR builds on HDDS-2459 and chances the DatanodeAdminMonitor to use the newly provided ContainerReplicaCount object to track the under replicated containers on a node and move the node to the next stages in the decommission / maintenance workflow when they are all sufficiently replicated.
   
   Once the replication is completed, the node will be moved to either complete (ending the decommission process) or go into a pending state waiting on maintenance to complete.
   
   This PR is a significant refactor of the DatanodeAdminMonitor, but previously it was incomplete so the bulk of the code is new.
   
   There are also a few minor refactors to other classes:
   
    * Removed the isHealthy() method from ReplicationManager and put it into ContainerReplicaCounts.
    * Pulled SimpleMockNodeManager into its own class (previously an inner class in TestReplicationManager) and enhanced it somewhat. HDDS-2673 is raised to consider merging it with MockNodeManager
    * ContainerReplicaCount now also takes a container object inorder to implement the isHealthy method.
    * TestDatanodeAdminMonitor now mocks all dependencies to allow for simpler and faster tests, avoiding MiniCluster.
   
   Note that these changes do not consider the new commands which must be sent to the Datanodes to change their admin state as part of HDDS-2592. Those enhancement will be made as part of that Jira.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2593
   
   ## How was this patch tested?
   
   Various new unit tests have been added.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org