[GitHub] [incubator-uniffle] cchung100m commented on a diff in pull request #984: [#363] refactor: Make the coordinator client managed by CoordinatorClientFactory singleton

["cchung100m (via GitHub)" <gi...@apache.org>]

cchung100m commented on code in PR #984:
URL: https://github.com/apache/incubator-uniffle/pull/984#discussion_r1264645844


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java:
##########
@@ -92,8 +92,9 @@ public static ShuffleManager loadShuffleManager(String name, SparkConf conf, boo
   public static List<CoordinatorClient> createCoordinatorClients(SparkConf sparkConf) {
     String clientType = sparkConf.get(RssSparkConfig.RSS_CLIENT_TYPE);
     String coordinators = sparkConf.get(RssSparkConfig.RSS_COORDINATOR_QUORUM);
-    CoordinatorClientFactory coordinatorClientFactory = new CoordinatorClientFactory(ClientType.valueOf(clientType));
-    return coordinatorClientFactory.createCoordinatorClient(coordinators);
+    CoordinatorClientFactory factory = CoordinatorClientFactory.getInstance();

Review Comment:
   Hi @zuston 
   
   Sorry for the late reply! I updated the part you mentioned but encountered some tricky errors. It would be appreciated if you are available to help me. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org