You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/01/20 14:22:39 UTC

[commons-dbcp] 01/04: More strict check in PooledConnectionImpl.assertOpen()

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit 490e5dcaf041cc315a36f40c5647052c544a7be4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jan 20 09:00:35 2023 -0500

    More strict check in PooledConnectionImpl.assertOpen()
---
 .../java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
index 8e271c5c..b2e64b19 100644
--- a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
+++ b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
@@ -140,7 +140,7 @@ final class PooledConnectionImpl
      * Throws an SQLException, if isClosed is true
      */
     private void assertOpen() throws SQLException {
-        if (closed) {
+        if (closed || connection == null) {
             throw new SQLException(CLOSED);
         }
     }