[jira] Commented: (TORQUE-39) Wrong database name in generated XML schema with jdbc task

["Thomas Fischer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TORQUE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534607 ] 

Thomas Fischer commented on TORQUE-39:
--------------------------------------

I am not convinced about adding a new property.
a) it is a lot of work. The ant, maven1 and maven2 part need to be considered.
b) We have already a lot of properties. Is this worth yet another one ?

My suggestion is the following:
- If someone finds the new property is worth the trouble and creates a patch, I'd test and commit it.
- If not, I'd change the database name from the db username to "default". It will work in the most setups, and if someone does something unusual, he has to change the database name anyway.

If you want to create a patch, please indicate so in the next few days.

> Wrong database name in generated XML schema with jdbc task
> ----------------------------------------------------------
>
>                 Key: TORQUE-39
>                 URL: https://issues.apache.org/jira/browse/TORQUE-39
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.2
>            Reporter: Thoralf Rickert
>
> In org.apache.torque.task.TorqueJDBCTransformTask#generateXML() is a bug in line 196.
> 195:            databaseNode = doc.createElement("database");
> 196:            databaseNode.setAttribute("name", dbUser);
> This would generate a wrong XML schema <database name="dbUser"> instead of <database name="databaseName">...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org