[GitHub] [spark] huaxingao commented on a change in pull request #26322: [SPARK-29656][ML][PYSPARK] ML algs expose aggregationDepth

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #26322: [SPARK-29656][ML][PYSPARK] ML algs expose aggregationDepth
URL: https://github.com/apache/spark/pull/26322#discussion_r340847003
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala
 ##########
 @@ -34,7 +34,8 @@ import org.apache.spark.sql.types.{StructField, StructType}
 /**
  * Params for [[RobustScaler]] and [[RobustScalerModel]].
  */
-private[feature] trait RobustScalerParams extends Params with HasInputCol with HasOutputCol {
+private[feature] trait RobustScalerParams extends Params with HasInputCol with HasOutputCol
+  with HasAggregationDepth {
 
 Review comment:
   I guess you forgot to put ```setAggregationDepth``` in ```class RobustScaler```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org