You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "paulstaab (via GitHub)" <gi...@apache.org> on 2023/10/05 11:31:03 UTC
[PR] [SPARK-40154][Python][Docs] Correct storage level in Dataframe.cache docstring [spark]
paulstaab opened a new pull request, #43229:
URL: https://github.com/apache/spark/pull/43229
### What changes were proposed in this pull request?
Corrects the docstring `DataFrame.cache` to give the correct storage level after it changed with Spark 3.0. It seems that the docstring of `DataFrame.persist` was updated, but `cache` was forgotten.
### Why are the changes needed?
The doctoring claims that `cache` uses serialised storage, while it actually uses deserialised storage. I confirmed that this is still the case with Spark 3.5.0 using the example code from the Jira ticket.
### Does this PR introduce _any_ user-facing change?
Yes, the docstring changes.
### How was this patch tested?
The Github actions workflow succeeded.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-40154][Python][Docs] Correct storage level in Dataframe.cache docstring [spark]
Posted by "paulstaab (via GitHub)" <gi...@apache.org>.
paulstaab commented on PR #43229:
URL: https://github.com/apache/spark/pull/43229#issuecomment-1778628315
@srowen you reviewed the corresponding change for `.persist()` a [few years back](https://github.com/apache/spark/commit/6f36db1fa511940dd43d597b7fe337fc3d5c2558). Can you review this change as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-40154][Python][Docs] Correct storage level in Dataframe.cache docstring [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43229:
URL: https://github.com/apache/spark/pull/43229#issuecomment-1779180612
Merged to master/3.5/3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-40154][Python][Docs] Correct storage level in Dataframe.cache docstring [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #43229: [SPARK-40154][Python][Docs] Correct storage level in Dataframe.cache docstring
URL: https://github.com/apache/spark/pull/43229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org