You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by hsaputra <gi...@git.apache.org> on 2015/04/22 20:19:41 UTC
[GitHub] incubator-twill pull request: TWILL-128 Change the ZKBrokerService...
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/31
TWILL-128 Change the ZKBrokerService to be public so it could be used outside the package.
Make ZKBrokerService to have public modifier so it could be used outside the package private.
The BrokerService interface that ZKBrokerService implemented is already public so it would be
helpful to make this implementation to be public so it could be used by external projects or code
when using Apache Kafka with Simple Customer APIs to resolve leader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill TWILL-128_change_ZKBrokerService_to_be_public
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit a7878752b48002843392db35ecf26ebc2919372a
Author: hsaputra <hs...@apache.org>
Date: 2015-04-22T18:15:55Z
TWILL-128 Change the ZKBrokerService to be public so it could be used outside the package.
Make ZKBrokerService to have public modifier so it could be used outside the package private.
The BrokerService interface that ZKBrokerService implemented is already public so it would be
helpful to make this implementation to be public so it could be used by external projects or code
when using Apache Kafka with Simple Customer APIs to resolve leader.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: TWILL-128 Change the ZKBrokerService...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/31#issuecomment-95427430
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: TWILL-128 Change the ZKBrokerService...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/31#issuecomment-95427653
Merged to master. Please close PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: TWILL-128 Change the ZKBrokerService...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra closed the pull request at:
https://github.com/apache/incubator-twill/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---