You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/05/24 19:16:32 UTC

[GitHub] [bookkeeper] dlg99 opened a new pull request #2719: Update bc tests to include versions up to 4.14.0

dlg99 opened a new pull request #2719:
URL: https://github.com/apache/bookkeeper/pull/2719


   ### Motivation
   
   4.14.0 release 
   
   ### Changes
   
   followed https://bookkeeper.apache.org/community/release_guide/#verify-docker-image and used https://github.com/apache/bookkeeper/pull/2171 as example
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2719: Update bc tests to include versions up to 4.14.0

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2719:
URL: https://github.com/apache/bookkeeper/pull/2719#discussion_r638894060



##########
File path: tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
##########
@@ -202,7 +202,70 @@ class TestCompatUpgrade {
     }
 
     @Test
-    public void test472toCurrentMaster() throws Exception {
-        testUpgrade("4.7.2", System.getProperty("currentVersion"))
+    public void test472to480() throws Exception {
+        testUpgrade("4.7.2", "4.8.0")
+    }
+
+    @Test
+    public void test480to481() throws Exception {
+        testUpgrade("4.8.0", "4.8.1")

Review comment:
       can we drop this old stuff?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 merged pull request #2719: Update bc tests to include versions up to 4.14.0

Posted by GitBox <gi...@apache.org>.
dlg99 merged pull request #2719:
URL: https://github.com/apache/bookkeeper/pull/2719


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2719: Update bc tests to include versions up to 4.14.0

Posted by GitBox <gi...@apache.org>.
dlg99 commented on a change in pull request #2719:
URL: https://github.com/apache/bookkeeper/pull/2719#discussion_r638912654



##########
File path: tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
##########
@@ -202,7 +202,70 @@ class TestCompatUpgrade {
     }
 
     @Test
-    public void test472toCurrentMaster() throws Exception {
-        testUpgrade("4.7.2", System.getProperty("currentVersion"))
+    public void test472to480() throws Exception {
+        testUpgrade("4.7.2", "4.8.0")
+    }
+
+    @Test
+    public void test480to481() throws Exception {
+        testUpgrade("4.8.0", "4.8.1")

Review comment:
       @eolivelli I added issue https://github.com/apache/bookkeeper/issues/2721 to track this request. I think it makes sense to do that i separate PR/have a larger group of committers to chirp in on how far back eh backwards compat should go




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org