You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/10/27 22:30:59 UTC
[jira] Created: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
bug in CollatedOrderPreservingPartitioner.midpoint
--------------------------------------------------
Key: CASSANDRA-519
URL: https://issues.apache.org/jira/browse/CASSANDRA-519
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jonathan Ellis
Assignee: Stu Hood
Priority: Minor
Fix For: 0.5
assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-519:
-------------------------------------
Fix Version/s: 0.9
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.9
>
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-519:
-------------------------------
Attachment: 519-biginteger-midpoint.diff
The implementations of midpoint in RPP and OPP were fairly optimized, but we would have needed to reimplement more of the operations in BigInteger in order to support wrapping ranges.
Instead, this patch reuses the BigInteger based midpoint implementation, and moves it into FBUtilities.midpoint. The partitioners convert their tokens into bit arrays represented as BigIntegers.
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 519-biginteger-midpoint.diff
>
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770661#action_12770661 ]
Stu Hood commented on CASSANDRA-519:
------------------------------------
IPartitioner.midpoint() doesn't currently require implementations to support wrapping ranges. I'll get to this eventually, but it doesn't look like midpoint is going to be necessary/helpful for 192, like I originally thought.
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.5
>
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784526#action_12784526 ]
Stu Hood commented on CASSANDRA-519:
------------------------------------
I'll try and get to this one this week.
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.9
>
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-519:
-------------------------------------
Fix Version/s: (was: 0.5)
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-519) bug in
CollatedOrderPreservingPartitioner.midpoint
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788066#action_12788066 ]
Hudson commented on CASSANDRA-519:
----------------------------------
Integrated in Cassandra #282 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/282/])
> bug in CollatedOrderPreservingPartitioner.midpoint
> --------------------------------------------------
>
> Key: CASSANDRA-519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-519
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.5
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 519-biginteger-midpoint.diff
>
>
> assert FBUtilities.isEqualBits(MINIMUM.token, rbytes);
> fails frequently when running the test added for CASSANDRA-517. just revert patch 03 and it will fail several times out of 10 test runs (when range3 is a wrapping range, presumably)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.