[GitHub] Ovilia commented on a change in pull request #9171: fix #8009 & #5969, symbol symbolSize and opacity setting for category itemStyle in graph

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #9171: fix #8009 & #5969, symbol symbolSize and opacity setting for category itemStyle in graph
URL: https://github.com/apache/incubator-echarts/pull/9171#discussion_r223922421
 
 

 ##########
 File path: src/chart/graph/categoryVisual.js
 ##########
 @@ -31,11 +31,25 @@ export default function (ecModel) {
             var name = categoriesData.getName(idx);
             // Add prefix to avoid conflict with Object.prototype.
             categoryNameIdxMap['ec-' + name] = idx;
-
             var itemModel = categoriesData.getItemModel(idx);
+
             var color = itemModel.get('itemStyle.color')
                 || seriesModel.getColorFromPalette(name, paletteScope);
             categoriesData.setItemVisual(idx, 'color', color);
+            var opacity = itemModel.get('itemStyle.opacity')
+                || 1;
+            categoriesData.setItemVisual(idx, 'opacity', opacity);
+            var itemSymbolType = itemModel.getShallow('symbol', true);
+            var itemSymbolSize = itemModel.getShallow('symbolSize',
+                true);
 
 Review comment:
   New line is no need here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org