You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2009/07/02 06:16:47 UTC
[jira] Issue Comment Edited: (LUCENE-1728) Move
SmartChineseAnalyzer & resources to own contrib project
[ https://issues.apache.org/jira/browse/LUCENE-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726314#action_12726314 ]
Simon Willnauer edited comment on LUCENE-1728 at 7/1/09 9:14 PM:
-----------------------------------------------------------------
bq. If i "svn move" the files in my local, and submit a patch, will it ensure that history is preserved? I am not an svn expert.
No. an svn copy (or svn move) will not be reflected in a patch. If you "svn move A B" and create a patch from your local WC the history of A will be lost. I guess I should do the moveing and commit it, the refactoring should be done afterwards. Would that make sense to you?!
simon
was (Author: simonw):
bq. If i "svn move" the files in my local, and submit a patch, will it ensure that history is preserved? I am not an svn expert.
No. an svn copy (or svn move) will not be reflected in a patch. I guess I should do the moveing and commit it and the refactoring should be done afterwards. Would that make sense to you?!
simon
> Move SmartChineseAnalyzer & resources to own contrib project
> ------------------------------------------------------------
>
> Key: LUCENE-1728
> URL: https://issues.apache.org/jira/browse/LUCENE-1728
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 2.9
>
>
> SmartChineseAnalyzer depends on a large dictionary that causes the analyzer jar to grow up to 3MB. The dictionary is quite big compared to all the other resouces / class files contained in that jar.
> Having a separate analyzer-cn contrib project enables footprint-sensitive users (e.g. using lucene on a mobile phone) to include analyzer.jar without getting into trouble with disk space.
> Moving SmartChineseAnalyzer to a separate project could also include a small refactoring as Robert mentioned in [LUCENE-1722|https://issues.apache.org/jira/browse/LUCENE-1722] several classes should be package protected, members and classes could be final, commented syserr and logging code should be removed etc.
> I set this issue target to 2.9 - if we can not make it until then feel free to move it to 3.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org