You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Dragan Sahpaski (Commented) (JIRA)" <ji...@apache.org> on 2012/03/06 14:32:58 UTC

[jira] [Commented] (TAP5-1842) @Startup should support id and constraints

    [ https://issues.apache.org/jira/browse/TAP5-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223254#comment-13223254 ] 

Dragan Sahpaski commented on TAP5-1842:
---------------------------------------

I like it. I think it would be useful.

Cheers
                
> @Startup should support id and constraints
> ------------------------------------------
>
>                 Key: TAP5-1842
>                 URL: https://issues.apache.org/jira/browse/TAP5-1842
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>            Reporter: Denis Stepanov
>
> It would be nice to have something like:
> @Startup(id = "DBInit", constraints = "before:*")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (TAP5-1842) @Startup should support id and constraints

Posted by Denis Stepanov <de...@gmail.com>.
> Doesn't contributing to the RegistryStartup service, which has an ordered configuration, does exactly what's been asked here?

Yes it does, but it is a lot messier, you need an inner class, and so on. Specialy when you are using @Startup and then you need an order.

Whole purpose of the @Startup is that you don't need to add an contribution, as it says in JavaDoc:  

"Instead of making contributions to the RegistryStartup service configuration you can provide startup methods inside your modules."

> I don't see the need for two different ways to do the same thing. 


There are many cases in Tapestry when you can do one thing in two different ways, it doesn't mean it's a bad thing.

> If I remember correctly, we had this discussion already. IMO, @Startup shouldn't have any order. 

It doesn't have an order when you don't need it, if you want an order you can have it. I don't see why anyone should be against it.

If there is already @Startup annotation why not to make it more useful?

Denis

Mar 6, 2012 v 2:54 PM, Igor Drobiazko:

> If I remember correctly, we had this discussion already. IMO, @Startup
> shouldn't have any order. If you need some kind of order, do it as Thiago
> suggested or build your own service with ordered configuration which you
> inject into a startup method.
> 
> On Tue, Mar 6, 2012 at 2:48 PM, Thiago H. de Paula Figueiredo <
> thiagohp@gmail.com> wrote:
> 
>> On Tue, 06 Mar 2012 10:32:58 -0300, Dragan Sahpaski (Commented) (JIRA) <
>> jira@apache.org> wrote:
>> 
>> 
>>>   [ https://issues.apache.org/**jira/browse/TAP5-1842?page=**
>>> com.atlassian.jira.plugin.**system.issuetabpanels:comment-**
>>> tabpanel&focusedCommentId=**13223254#comment-13223254<https://issues.apache.org/jira/browse/TAP5-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223254#comment-13223254>]
>>> 
>>> Dragan Sahpaski commented on TAP5-1842:
>>> ------------------------------**---------
>>> 
>>> I like it. I think it would be useful.
>>> 
>> 
>> Doesn't contributing to the RegistryStartup service, which has an ordered
>> configuration, does exactly what's been asked here? I don't see the need
>> for two different ways to do the same thing. As far as I can see, @Startup
>> was meant to be used in simpler cases (without ordering).
>> 
>> --
>> Thiago H. de Paula Figueiredo
>> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
>> and instructor
>> Owner, Ars Machina Tecnologia da Informação Ltda.
>> http://www.arsmachina.com.br
>> 
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org<de...@tapestry.apache.org>
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>> 
>> 
> 
> 
> -- 
> Best regards,
> 
> Igor Drobiazko
> http://tapestry5.de
> http://twitter.com/drobiazko


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [jira] [Commented] (TAP5-1842) @Startup should support id and constraints

Posted by Igor Drobiazko <ig...@gmail.com>.
If I remember correctly, we had this discussion already. IMO, @Startup
shouldn't have any order. If you need some kind of order, do it as Thiago
suggested or build your own service with ordered configuration which you
inject into a startup method.

On Tue, Mar 6, 2012 at 2:48 PM, Thiago H. de Paula Figueiredo <
thiagohp@gmail.com> wrote:

> On Tue, 06 Mar 2012 10:32:58 -0300, Dragan Sahpaski (Commented) (JIRA) <
> jira@apache.org> wrote:
>
>
>>    [ https://issues.apache.org/**jira/browse/TAP5-1842?page=**
>> com.atlassian.jira.plugin.**system.issuetabpanels:comment-**
>> tabpanel&focusedCommentId=**13223254#comment-13223254<https://issues.apache.org/jira/browse/TAP5-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223254#comment-13223254>]
>>
>> Dragan Sahpaski commented on TAP5-1842:
>> ------------------------------**---------
>>
>> I like it. I think it would be useful.
>>
>
> Doesn't contributing to the RegistryStartup service, which has an ordered
> configuration, does exactly what's been asked here? I don't see the need
> for two different ways to do the same thing. As far as I can see, @Startup
> was meant to be used in simpler cases (without ordering).
>
> --
> Thiago H. de Paula Figueiredo
> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
> and instructor
> Owner, Ars Machina Tecnologia da Informação Ltda.
> http://www.arsmachina.com.br
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org<de...@tapestry.apache.org>
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Best regards,

Igor Drobiazko
http://tapestry5.de
http://twitter.com/drobiazko

Re: [jira] [Commented] (TAP5-1842) @Startup should support id and constraints

Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
On Tue, 06 Mar 2012 10:32:58 -0300, Dragan Sahpaski (Commented) (JIRA)  
<ji...@apache.org> wrote:

>
>     [  
> https://issues.apache.org/jira/browse/TAP5-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223254#comment-13223254  
> ]
>
> Dragan Sahpaski commented on TAP5-1842:
> ---------------------------------------
>
> I like it. I think it would be useful.

Doesn't contributing to the RegistryStartup service, which has an ordered  
configuration, does exactly what's been asked here? I don't see the need  
for two different ways to do the same thing. As far as I can see, @Startup  
was meant to be used in simpler cases (without ordering).

-- 
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,  
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org