You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/04/21 10:59:20 UTC

[GitHub] [calcite] godfreyhe opened a new pull request, #2775: [CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values

godfreyhe opened a new pull request, #2775:
URL: https://github.com/apache/calcite/pull/2775

   Currently, only part of RelNodes support SQL hint, such as: Scan, Project, Join. Filter, SetOp, Sort, Window, Values do not support hint yet, which cause hint propagation can not be supported. This pr aims to support those nodes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [calcite] danny0405 closed pull request #2775: [CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values

Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #2775: [CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values
URL: https://github.com/apache/calcite/pull/2775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [calcite] danny0405 commented on a diff in pull request #2775: [CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values

Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #2775:
URL: https://github.com/apache/calcite/pull/2775#discussion_r855799710


##########
core/src/main/java/org/apache/calcite/rel/core/Sort.java:
##########
@@ -86,17 +126,7 @@ protected Sort(
       RelCollation collation,
       @Nullable RexNode offset,
       @Nullable RexNode fetch) {
-    super(cluster, traits, child);

Review Comment:
   Thanks for the contribution, overall looks good, there are some compile failure, can you fix that ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [calcite] godfreyhe commented on pull request #2775: [CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on PR #2775:
URL: https://github.com/apache/calcite/pull/2775#issuecomment-1107793934

   cc @danny0405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org