You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2014/09/14 19:43:37 UTC
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3
Encode seq before sending request
CouchDB 2.0 sequences are lists (of form [non_neg_integer(),
binary()]) where previously they were strings (either as binary or as
list) or numbers. The replicator calls iolist_to_binary on all
parameters which scrambles this new format.
Ensure we've JSON encoded the since value to a binary before calling send_req.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch-replicator malformed-since
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-replicator/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 6e96c2b9eb552d62ee52955226dacc487dc92d4b
Author: Robert Newson <rn...@apache.org>
Date: 2014-09-14T17:40:08Z
Encode seq before sending request
CouchDB 2.0 sequences are lists (of form [non_neg_integer(),
binary()]) where previously they were strings (either as binary or as
list) or numbers. The replicator calls iolist_to_binary on all
parameters which scrambles this new format.
Ensure we've JSON encoded the since value to a binary before calling send_req.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-69912288
+1, I'll try to get to this today unless you beat me to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb-couch-replicator/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
Posted by mikewallace1979 <gi...@git.apache.org>.
Github user mikewallace1979 commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-55574870
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-69914867
oh, this happened ages ago in 363093f480fb5df6e337c9de308f0be9b31da783, derp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Encode seq before sending r...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-69664599
+1
@rnewson ok with merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---