You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/22 21:25:09 UTC
[GitHub] [spark] c21 commented on a change in pull request #33828: [SPARK-36579][CORE][SQL] Make spark source stagingDir can be customized
c21 commented on a change in pull request #33828:
URL: https://github.com/apache/spark/pull/33828#discussion_r734850205
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3412,6 +3412,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val EXEC_STAGING_DIR = buildConf("spark.sql.exec.stagingDir")
+ .doc("The staging directory of Spark job. Spark uses it to deal with files with " +
+ "absolute output path, or writing data into partitioned directory when " +
+ "dynamic partition overwrite mode. " +
+ "Default value means staging dir is under table path.")
Review comment:
nit: `staging dir` -> `staging directory`
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3412,6 +3412,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val EXEC_STAGING_DIR = buildConf("spark.sql.exec.stagingDir")
+ .doc("The staging directory of Spark job. Spark uses it to deal with files with " +
+ "absolute output path, or writing data into partitioned directory when " +
Review comment:
nit: `when dynamic partition overwrite mode.` -> `when dynamic partition overwrite mode is on.` ?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3412,6 +3412,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val EXEC_STAGING_DIR = buildConf("spark.sql.exec.stagingDir")
+ .doc("The staging directory of Spark job. Spark uses it to deal with files with " +
+ "absolute output path, or writing data into partitioned directory when " +
+ "dynamic partition overwrite mode. " +
+ "Default value means staging dir is under table path.")
+ .version("3.3.0")
+ .internal()
+ .stringConf
+ .createWithDefault(".spark-staging")
Review comment:
shall we add a `checkValue()` to check the config value is not empty string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org