You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/08/29 02:06:00 UTC
[jira] [Work logged] (GOBBLIN-2145) fix bug in getting flow status
[ https://issues.apache.org/jira/browse/GOBBLIN-2145?focusedWorklogId=932301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932301 ]
ASF GitHub Bot logged work on GOBBLIN-2145:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/24 02:05
Start Date: 29/Aug/24 02:05
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4040:
URL: https://github.com/apache/gobblin/pull/4040#discussion_r1735474654
##########
gobblin-runtime/src/test/java/org/apache/gobblin/service/monitoring/FlowStatusGeneratorTest.java:
##########
@@ -77,12 +77,12 @@ public void skipFlowConcurrentCheckSameFlowExecutionId() {
JobStatus jobStatus = JobStatus.builder().flowGroup(flowGroup).flowName(flowName).flowExecutionId(flowExecutionId)
.jobName(JobStatusRetriever.NA_KEY).jobGroup(JobStatusRetriever.NA_KEY).eventName(ExecutionStatus.COMPILED.name()).build();
Iterator<JobStatus> jobStatusIterator = Lists.newArrayList(jobStatus).iterator();
- FlowStatus flowStatus = new FlowStatus(flowName,flowGroup,flowExecutionId,jobStatusIterator,ExecutionStatus.COMPILED);
- when(jobStatusRetriever.getAllFlowStatusesForFlowExecutionsOrdered(flowName, flowGroup)).thenReturn(
+ FlowStatus flowStatus = new FlowStatus(flowName, flowGroup, flowExecutionId, jobStatusIterator,ExecutionStatus.COMPILED);
Review Comment:
yea, i am not comfortable with this state either. lets change it in some other PR, this one is quite urgent
Issue Time Tracking
-------------------
Worklog Id: (was: 932301)
Remaining Estimate: 0h
Time Spent: 10m
> fix bug in getting flow status
> ------------------------------
>
> Key: GOBBLIN-2145
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2145
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)