[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive ser...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16626#discussion_r105286751
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -504,94 +504,57 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
        * Note: As of now, this doesn't support altering table schema, partition column names and bucket
        * specification. We will ignore them even if users do specify different values for these fields.
        */
    -  override def alterTable(tableDefinition: CatalogTable): Unit = withClient {
    -    assert(tableDefinition.identifier.database.isDefined)
    -    val db = tableDefinition.identifier.database.get
    -    requireTableExists(db, tableDefinition.identifier.table)
    -    verifyTableProperties(tableDefinition)
    +  override def alterTable(newTableDefinition: CatalogTable): Unit = withClient {
    --- End diff --
    
    now we have a `alterSchema` method in `ExternalCatalog`, we can use that instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org