You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonas Dohse (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 14:21:20 UTC
[jira] [Created] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
CQL 3.0 does not work in cqlsh with uppercase SELECT
----------------------------------------------------
Key: CASSANDRA-4161
URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
Project: Cassandra
Issue Type: Bug
Components: Tools
Affects Versions: 1.1.0
Environment: cqlsh
Reporter: Jonas Dohse
Priority: Minor
Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
Example:
select * from test ORDER BY number; # works
SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "Jonas Dohse (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonas Dohse updated CASSANDRA-4161:
-----------------------------------
Attachment: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch
Fix problem by converting command to lower case
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "Jonas Dohse (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257385#comment-13257385 ]
Jonas Dohse commented on CASSANDRA-4161:
----------------------------------------
Works for me™
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257548#comment-13257548 ]
paul cannon commented on CASSANDRA-4161:
----------------------------------------
bq. I'm wondering why CQL is being parsed in the client at all? Couldn't we just handle the exceptions thrown by cassandra? That way we wouldn't have to keep cqlsh in sync with CQL development on the C*-side.
cqlsh has to attempt to parse input in order to recognize keyspace switches, provide tab-completion, implement the cqlsh-specific commands, separate multiple statements, and (in the future) to allow things like CASSANDRA-3799.
Yes, of course, if cqlsh can identify a CQL statement but can't parse it, and it doesn't recognize the command word as being cqlsh-specific, it should pass the CQL on untouched to Cassandra. The problem in this ticket was with cqlsh deciding incorrectly that the user intended to give a cqlsh-only command.
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "Christoph Tavan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257361#comment-13257361 ]
Christoph Tavan commented on CASSANDRA-4161:
--------------------------------------------
I'm wondering why CQL is being parsed in the client at all? Couldn't we just handle the exceptions thrown by cassandra? That way we wouldn't have to keep cqlsh in sync with CQL development on the C*-side.
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4161:
----------------------------------------
Reviewer: thepaul
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "paul cannon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
paul cannon updated CASSANDRA-4161:
-----------------------------------
Attachment: 4161.patch.txt
Good catch, thanks. I do think that a slightly better solution is to do the downcasing in a more specific place, though, as attached. I would like to keep original case intact in cmdword, even if it's just for error messages right now.
Does this work for you?
(also available in my 4161 branch in github: https://github.com/thepaul/cassandra/tree/4161)
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257549#comment-13257549 ]
paul cannon commented on CASSANDRA-4161:
----------------------------------------
+1 for 4161.patch.txt.
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4161) CQL 3.0 does not work in cqlsh
with uppercase SELECT
Posted by "Jonas Dohse (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257588#comment-13257588 ]
Jonas Dohse commented on CASSANDRA-4161:
----------------------------------------
+1 for 4161.patch.txt
> CQL 3.0 does not work in cqlsh with uppercase SELECT
> ----------------------------------------------------
>
> Key: CASSANDRA-4161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4161
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.1.0
> Environment: cqlsh
> Reporter: Jonas Dohse
> Priority: Minor
> Labels: cql3, cqlsh
> Attachments: 0001-Allow-CQL-3.0-with-uppercase-SELECT-statement.patch, 4161.patch.txt
>
>
> Uppercase SELECT prevents usage of CQL 3.0 features like ORDER BY
> Example:
> select * from test ORDER BY number; # works
> SELECT * from test ORDER BY number; # fails
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira