You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/01/04 12:16:01 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request #2102: Inlong 2099
kipshi opened a new pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #2099
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778687708
##########
File path: inlong-manager/manager-web/src/test/java/org/apache/inlong/manager/service/workflow/WorkflowServiceTest.java
##########
@@ -36,6 +41,20 @@
@Autowired
private WorkflowDataAccessor workflowDataAccessor;
+ @Autowired
+ private PlatformTransactionManager platformTransactionManager;
+
+ @Test
+ public void testTransactionManager(){
+ System.out.println(platformTransactionManager.getClass().getName());
+ DefaultTransactionDefinition transactionDefinition = new DefaultTransactionDefinition();
+ transactionDefinition.setPropagationBehavior(TransactionDefinition.PROPAGATION_NESTED);
+
+ TransactionStatus status = platformTransactionManager.getTransaction(transactionDefinition);
+ System.out.println(status.getClass().getName());
Review comment:
It is recommended to use assertions instead of `System.out.println()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778498292
##########
File path: inlong-manager/pom.xml
##########
@@ -60,6 +60,7 @@
<gson.version>2.8.6</gson.version>
<json-simple.version>1.1.1</json-simple.version>
<jackson.version>2.9.10.5</jackson.version>
Review comment:
I don’t know which version is more suitable, the jackson.version 2.9.5 version seems to have loopholes too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778507884
##########
File path: inlong-manager/pom.xml
##########
@@ -60,6 +60,7 @@
<gson.version>2.8.6</gson.version>
<json-simple.version>1.1.1</json-simple.version>
<jackson.version>2.9.10.5</jackson.version>
Review comment:
In this issue-[https://github.com/FasterXML/jackson-databind/issues/3004](https://github.com/FasterXML/jackson-databind/issues/3004), it is pointed out that the safe version number is 2.9.10.8, please upgrade to this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778507683
##########
File path: inlong-manager/pom.xml
##########
@@ -60,6 +60,7 @@
<gson.version>2.8.6</gson.version>
<json-simple.version>1.1.1</json-simple.version>
<jackson.version>2.9.10.5</jackson.version>
Review comment:
In this [issue-https://github.com/FasterXML/jackson-databind/issues/3004](https://github.com/FasterXML/jackson-databind/issues/3004), it is pointed out that the safe version number is 2.9.10.8, please upgrade to this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778501356
##########
File path: inlong-manager/pom.xml
##########
@@ -60,6 +60,7 @@
<gson.version>2.8.6</gson.version>
<json-simple.version>1.1.1</json-simple.version>
<jackson.version>2.9.10.5</jackson.version>
Review comment:
#2099 say the minimum repair version is `2.9.10.5`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#discussion_r778507884
##########
File path: inlong-manager/pom.xml
##########
@@ -60,6 +60,7 @@
<gson.version>2.8.6</gson.version>
<json-simple.version>1.1.1</json-simple.version>
<jackson.version>2.9.10.5</jackson.version>
Review comment:
In this [issue-https://github.com/FasterXML/jackson-databind/issues/3004](https://github.com/FasterXML/jackson-databind/issues/3004), it is pointed out that the safe version number is 2.9.10.8, please upgrade to this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2102: [INLONG-2099][inlong-manager] The referenced jackson-databind@2.9.5 component has serious vulnerabilities
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2102:
URL: https://github.com/apache/incubator-inlong/pull/2102#issuecomment-1005639659
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2102](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbf2af3) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/00d311eaefcf56bcdb05359db02c8939d3a70077?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00d311e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2102 +/- ##
============================================
+ Coverage 12.26% 12.29% +0.02%
- Complexity 1157 1159 +2
============================================
Files 413 413
Lines 35215 35215
Branches 5542 5542
============================================
+ Hits 4318 4328 +10
+ Misses 30125 30117 -8
+ Partials 772 770 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/2102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `34.51% <0.00%> (+0.44%)` | :arrow_up: |
| [.../inlong/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-inlong/pull/2102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `40.00% <0.00%> (+1.11%)` | :arrow_up: |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/2102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00d311e...bbf2af3](https://codecov.io/gh/apache/incubator-inlong/pull/2102?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org