[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

[GitBox <gi...@apache.org>]

Cpaulyz commented on code in PR #8771:
URL: https://github.com/apache/iotdb/pull/8771#discussion_r1063289486


##########
server/src/main/java/org/apache/iotdb/db/metadata/plan/schemaregion/read/IShowNodesPlan.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+package org.apache.iotdb.db.metadata.plan.schemaregion.read;
+
+public interface IShowNodesPlan extends IShowSchemaPlan {
+
+  int getLevel();

Review Comment:
   Add some description. 
   ```suggestion
   // Level query option started from 0. For example, level of root.sg.d1.s1 is 3.
     int getLevel();
   ```



##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGMemoryImpl.java:
##########
@@ -916,4 +862,40 @@ protected boolean processFullMatchedMNode(IMNode node, int idx, int level)
   }
 
   // endregion
+
+  // region Interfaces for schema reader
+  public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)

Review Comment:
   ```suggestion
     // region Interfaces for schema reader
     @Override
     public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)
   ```



##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGCachedImpl.java:
##########
@@ -1065,4 +1011,39 @@ public void updateMNode(IMNode node) throws MetadataException {
 
   // endregion
 
+  // region Interfaces for schema reader
+  public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)

Review Comment:
   Add interface `IMTreeBelowSG`
   ```suggestion
     // region Interfaces for schema reader
     @Override
     public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org