You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "sravankorumilli (JIRA)" <ji...@apache.org> on 2011/04/16 11:54:05 UTC

[jira] [Commented] (HDFS-673) BlockReceiver#PacketResponder should not remove a packet from the ack queue before its ack is sent

    [ https://issues.apache.org/jira/browse/HDFS-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020581#comment-13020581 ] 

sravankorumilli commented on HDFS-673:
--------------------------------------

Hi Hairong, I am using 20.1 hadoop, I did not find the problem that you are actually mentioning. What I am getting from the code is Dataxceiver thread will close the streams only after the responder thread has been completed. Can you please check and validate my comments, if I am wrong can you explain the problem.

> BlockReceiver#PacketResponder should not remove a packet from the ack queue before its ack is sent
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-673
>                 URL: https://issues.apache.org/jira/browse/HDFS-673
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: pkgRmOrder.patch
>
>
> After a BlockReceiver finish receiving the last packet of a block, it waits until the ack queue becomes empty. It them assumes that all acks have been sent and shunts down network connections. The current code removes a packet from the ack queue before its ack is sent. So there is a chance that the connection gets closed before an ack is sent.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira