You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "vio-lin (via GitHub)" <gi...@apache.org> on 2023/04/23 08:17:16 UTC

[GitHub] [dubbo] vio-lin opened a new issue, #12164: ReferenceCountManagedChannel shoule add reference count when create

vio-lin opened a new issue, #12164:
URL: https://github.com/apache/dubbo/issues/12164

   <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
   
   - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
   
   ### Environment
   
   * Dubbo version: 2.7.23-SNAPSHOT
   * Operating System version: Windows7
   * Java version: jdk8
   
   ### Steps to reproduce this issue
   
   1. tow dubbo service in one instance
   3. client refre two service 
   4. when pull out one service the other client throw exception
   
   ### Expected Behavior
   
   <!-- What do you expect from the above steps?-->
   
   ### Actual Behavior
   
   <!-- What actually happens? -->
   
   If there is an exception, please attach the exception trace:
   
   ```
   Caused by: io.grpc.StatusRuntimeException: UNAVAILABLE: Channel shutdown invoked
   	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
   	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
   	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
   ```
   
   预期另外一个接口是没有报错的。
   对比两个相似的类 他们初始化的逻辑不对
   
   `org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient#ReferenceCountExchangeClient`
   
   ```java
     public ReferenceCountExchangeClient(ExchangeClient client) {
           this.client = client;
           referenceCount.incrementAndGet();
           this.url = client.getUrl();
       }
   ```
   
   `org.apache.dubbo.rpc.protocol.grpc.ReferenceCountManagedChannel ` 初始化的时候少算了一个referenceCount
   
   ```java
   public ReferenceCountManagedChannel(ManagedChannel delegated) {
           this.grpcChannel = delegated;
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] AlbumenJ commented on issue #12164: ReferenceCountManagedChannel shoule add reference count when create

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12164:
URL: https://github.com/apache/dubbo/issues/12164#issuecomment-1521197335

   2.7.x is no longer supported now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] vio-lin commented on issue #12164: ReferenceCountManagedChannel shoule add reference count when create

Posted by "vio-lin (via GitHub)" <gi...@apache.org>.
vio-lin commented on issue #12164:
URL: https://github.com/apache/dubbo/issues/12164#issuecomment-1534298540

   
   > From the perspective of the community, there are currently many versions maintained, which have a relatively large impact on the development of the community itself. So currently we don't consider fixing it on the 2.7.x version.
   
   可以的。我们初衷也是后面升级时,尽量找对旧应用使用问题少的版本。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] AlbumenJ commented on issue #12164: ReferenceCountManagedChannel shoule add reference count when create

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12164:
URL: https://github.com/apache/dubbo/issues/12164#issuecomment-1531498328

   > > Please try use triple in Dubbo 3.2.
   > 
   > Some applications prefer to use old version. Work for update is in progress. As the code is in old version, prefer to fix.
   
   From the perspective of the community, there are currently many versions maintained, which have a relatively large impact on the development of the community itself. So currently we don't consider fixing it on the 2.7.x version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] vio-lin commented on issue #12164: ReferenceCountManagedChannel shoule add reference count when create

Posted by "vio-lin (via GitHub)" <gi...@apache.org>.
vio-lin commented on issue #12164:
URL: https://github.com/apache/dubbo/issues/12164#issuecomment-1525566768

   > Please try use triple in Dubbo 3.2.
   
   Some applications prefer to use old version. Work for update is in progress.
   As the code is in old version, prefer to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] AlbumenJ commented on issue #12164: ReferenceCountManagedChannel shoule add reference count when create

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12164:
URL: https://github.com/apache/dubbo/issues/12164#issuecomment-1521197189

   Please try use triple in Dubbo 3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [I] ReferenceCountManagedChannel shoule add reference count when create [dubbo]

Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM closed issue #12164: ReferenceCountManagedChannel shoule add reference count when create
URL: https://github.com/apache/dubbo/issues/12164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org