You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/19 13:16:42 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2232:
Decouple DruidDataSource in ConnectionFactory and cache DataSource instance
codecov-io commented on issue #2232: Decouple DruidDataSource in ConnectionFactory and cache DataSource instance
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2232#issuecomment-601171724
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=h1) Report
> Merging [#2232](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/ff0d6c6c5fc2ae0f86a6ad013019d253e580160c&el=desc) will **decrease** coverage by `1.48%`.
> The diff coverage is `28.08%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2232 +/- ##
============================================
- Coverage 31.95% 30.46% -1.49%
- Complexity 1511 1665 +154
============================================
Files 311 336 +25
Lines 15402 17825 +2423
Branches 1864 2238 +374
============================================
+ Hits 4922 5431 +509
- Misses 9968 11837 +1869
- Partials 512 557 +45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `77.55% <ø> (ø)` | `13.00 <0.00> (+1.00)` | |
| [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/dolphinscheduler/alert/utils/FuncUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9GdW5jVXRpbHMuamF2YQ==) | `91.66% <ø> (ø)` | `5.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | `33.33% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `5.40% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...scheduler/api/controller/DataSourceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YVNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `2.19% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...inscheduler/api/controller/ExecutorController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRXhlY3V0b3JDb250cm9sbGVyLmphdmE=) | `6.25% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `11.76% <ø> (+1.23%)` | `2.00 <0.00> (ø)` | |
| [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `0.65% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [126 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=footer). Last update [0714971...1f6a467](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services