[jira] [Commented] (LUCENE-6437) Improve test reproducibility of ConcurrentMergeScheduler

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501441#comment-14501441 ] 

Robert Muir commented on LUCENE-6437:
-------------------------------------

+1, this is great.

I think we just need tweaks to test.policy to add write access to the two new permissions. +1 to commit with that.

> Improve test reproducibility of ConcurrentMergeScheduler
> --------------------------------------------------------
>
>                 Key: LUCENE-6437
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6437
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-6437.patch
>
>
> If things go wrong based on merges with concurrentmergescheduler in tests, its always more difficult to reproduce.
> But we make it worse, CMS can base its behavior on:
> * number of cpus.
> * whether drives are SSDs.
> We should just allow a (undocumented, for testing) sysprop backdoor to override both of these. This way, it can be set to values completely based on the random seed in LuceneTestCase init, and its not a reproducibility trap.
> Its true we try to set explicit values for LuceneTestCase.newIndexWriterConfig() and so forth. But not all tests use randomized IW configs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org