You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Anton Luht (JIRA)" <ji...@apache.org> on 2006/08/29 18:58:23 UTC
[jira] Created: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Fix invalid assertion in thread_native_fat_monitor.c
----------------------------------------------------
Key: HARMONY-1340
URL: http://issues.apache.org/jira/browse/HARMONY-1340
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: Windows XP professional
Reporter: Anton Luht
java version "1.5.0"
pre-alpha : not complete or compatible
svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
http://incubator.apache.org/harmony
An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
Seems like assertion saved_recursion >= 0 is more appropriate here
at least with this assertion popup disappears and build proceeds
Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=all ]
weldon washburn reassigned HARMONY-1340:
----------------------------------------
Assignee: weldon washburn
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: weldon washburn
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=all ]
Geir Magnusson Jr closed HARMONY-1340.
--------------------------------------
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: Geir Magnusson Jr
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Anton Luht (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=all ]
Anton Luht updated HARMONY-1340:
--------------------------------
Attachment: patch.txt
the patch for the assertion
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=all ]
Geir Magnusson Jr resolved HARMONY-1340.
----------------------------------------
Resolution: Fixed
r449912
winxp - c-unit, smoke until LOS
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: Geir Magnusson Jr
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=all ]
Geir Magnusson Jr reassigned HARMONY-1340:
------------------------------------------
Assignee: Geir Magnusson Jr (was: weldon washburn)
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: Geir Magnusson Jr
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=comments#action_12435762 ]
Geir Magnusson Jr commented on HARMONY-1340:
--------------------------------------------
Why is that more appropriate? It's the opposite of what the code is now. Can you defend this in more detail?
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: weldon washburn
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1340) Fix invalid assertion in
thread_native_fat_monitor.c
Posted by "Artem Aliev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1340?page=comments#action_12435767 ]
Artem Aliev commented on HARMONY-1340:
--------------------------------------
The assertion in the current code is incorrect, it check that monitor is entered not more then once (recursion_count < 1)
It was left in the code by mistake.
The monitor recursion count could be any positive number (the number of nested monitorEnter calls).
So the fix is correct.
> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
> Key: HARMONY-1340
> URL: http://issues.apache.org/jira/browse/HARMONY-1340
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows XP professional
> Reporter: Anton Luht
> Assigned To: weldon washburn
> Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira