[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6260: risc-v/mpfs: apply IHC review fixes

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6260:
URL: https://github.com/apache/incubator-nuttx/pull/6260#discussion_r872020785


##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -1248,19 +1248,18 @@ int mpfs_ihc_init(void)
  *
  ****************************************************************************/
 
-uintptr_t up_addrenv_va_to_pa(FAR void *va_)
+uintptr_t up_addrenv_va_to_pa(FAR void *va)
 {
-  uintptr_t va = (uintptr_t)va_;
-
-  return va;
+  return (uintptr_t)va;
 }
 
 /****************************************************************************
  * Name: up_addrenv_pa_to_va
  *
  * Description:
  *   This is needed by openamp/libmetal/lib/system/nuttx/io.c. The
- *   physical memory is mapped as virtual.
+ *   physical memory is mapped as virtual.  FAR is here to match the original
+ *   declaration in arch.h.

Review Comment:
   ```suggestion
    *   physical memory is mapped as virtual.
   ```
   



##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -1272,5 +1271,5 @@ uintptr_t up_addrenv_va_to_pa(FAR void *va_)
 
 FAR void *up_addrenv_pa_to_va(uintptr_t pa)

Review Comment:
   ```suggestion
   void *up_addrenv_pa_to_va(uintptr_t pa)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org